Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rainerscript: new function "http_request" #2146

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
3 participants
@rgerhards
Copy link
Member

rgerhards commented Dec 1, 2017

closes #1977

@rgerhards rgerhards added this to the v8.32 milestone Dec 1, 2017

@rgerhards rgerhards force-pushed the rgerhards:i-1977 branch 6 times, most recently from 5e8a58d to 103d24e Dec 1, 2017

@rgerhards rgerhards force-pushed the rgerhards:i-1977 branch 3 times, most recently from 9126a61 to 8a2c01d Dec 12, 2017

@rgerhards rgerhards force-pushed the rgerhards:i-1977 branch from 8a2c01d to 49efb53 Dec 16, 2017

@rgerhards rgerhards merged commit a395a79 into rsyslog:master Dec 18, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
rsyslog centos6 rsyslog Build done
Details
rsyslog centos7 rsyslog Build done
Details
rsyslog debian rsyslog Build done
Details
rsyslog fedora23x32 rsyslog Build done
Details
rsyslog fedora26x64 rsyslog Build done
Details
rsyslog freebsd rsyslog Build done
Details
rsyslog raspbian rsyslog Build done
Details
rsyslog solaris10sparc rsyslog Build done
Details
rsyslog solaris10x64 rsyslog Build done
Details
rsyslog solaris11sparc rsyslog Build done
Details
rsyslog solaris11x64 rsyslog Build done
Details
rsyslog suse rsyslog Build done
Details
rsyslog ubuntu rsyslog Build done
Details
rsyslog ubuntu16 rsyslog Build done
Details

@rgerhards rgerhards deleted the rgerhards:i-1977 branch Dec 18, 2017

@rgerhards

This comment has been minimized.

Copy link
Member Author

rgerhards commented Dec 18, 2017

@Whissi @mbiebl This creates a new build requirement for libcurl for rsyslog core. I think this is available on almost all modern systems by default. Anyhow, if you see a problem, let me know and I'll add an ability to disable the need for libcurl.

@Whissi

This comment has been minimized.

Copy link
Contributor

Whissi commented Dec 18, 2017

Don't forget embedded devices. Please make this optional, i.e. allow to disable cURL integration via configure.

@mbiebl

This comment has been minimized.

Copy link
Contributor

mbiebl commented Dec 18, 2017

Fwiw, I share David's more general concerns in #1977 to build this directly into the core

@rgerhards

This comment has been minimized.

Copy link
Member Author

rgerhards commented Dec 18, 2017

OK, I'll first provide a switch to disable it.

Building it outside the core requires a whole new callable interface (for functions). Unfortunately I have no time to design and implement this ATM. So I hope it is OK to provide the switch initially.

In general, everything can be abused. It won't offer better performance if we do it via a message modification module. A prime legit case is to obtain AWS metadata and the like. I don't want to add a specialized function for each and every of such calls. With the ability to do a http request very easily and a bit of script logic, this is nicely and easily done.

rgerhards added a commit to rgerhards/rsyslog that referenced this pull request Dec 18, 2017

build: permit to disable libcurl for rsyslog core
currently, this disables the http_request() script function

see also rsyslog#2146 (comment)
see also rsyslog#2146 (comment)
@rgerhards

This comment has been minimized.

Copy link
Member Author

rgerhards commented Dec 18, 2017

FYI: PR for disabling: #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.