Skip to content

Add Lint CI config #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 19, 2021
Merged

Add Lint CI config #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
75bcfcc
Add Lint CI config
Tiryoh Jul 7, 2021
b4d147c
Fix MODULE_VERSION
Tiryoh Jul 7, 2021
4ddeb02
Fix typo
Tiryoh Jul 7, 2021
7546ae2
Apply clang-format
Tiryoh Jul 7, 2021
0db540f
Limit CI trigger
Tiryoh Jul 7, 2021
cc8ba54
Revert "Fix MODULE_VERSION" for CI testing
Tiryoh Jul 7, 2021
24c3d13
Revert "Revert "Fix MODULE_VERSION" for CI testing"
Tiryoh Jul 7, 2021
e7fde21
Merge branch 'master' into feature/add-lint
Jul 16, 2021
1c28328
Unify configuration files
Tiryoh Jul 19, 2021
007ee2e
Apply clang-format
Tiryoh Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/workflows/driver-cross-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,33 @@ on:
branches:
- master
paths:
- '.github/workflows/driver-cross-build.yml'
- '.test/bin/**'
- '.test/lint.sh'
- 'src/drivers/**'
- '.github/workflows/**'
pull_request:
types: [opened, synchronize]
paths:
- '.github/workflows/driver-cross-build.yml'
- '.test/bin/**'
- '.test/lint.sh'
- 'src/drivers/**'
- '.github/workflows/**'

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- uses: actions/setup-python@v2
with:
python-version: '3.x'

- name: Lint
run: |
./.test/lint.sh
build:
Copy link
Contributor

@ShotaAk ShotaAk Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintをワークフローではなくジョブにして、Lintが失敗したらクロスビルドをキャンセルするように変更するのはどうでしょうか？

Copy link
Contributor Author

@Tiryoh Tiryoh Jul 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1つのワークフローにまとめてLint失敗時はビルドテストしないようにしました。

https://github.com/rt-net/RaspberryPiMouse/runs/3100729669

Screenshot from 2021-07-19 13-58-22
Screenshot from 2021-07-19 14-00-31

needs: lint
strategy:
fail-fast: false
matrix:
Expand Down
Loading