Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

industrial_ciのワークフローを追加。READMEにワークフローの結果とdisplay.launchのスクショを追加。 #2

Merged
merged 3 commits into from
May 26, 2022

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented May 25, 2022

What does this implement/fix?

industiral_ciを実行するGitHub workflowファイルを追加します。
また、display.launchの実行画面のスクショをREADMEに追加します。

Does this close any currently open issues?

いいえ

How has this been tested?

READMEの手順でdisplay.launchが実行されることを確認しています。

Any other comments?

Checklists

@ShotaAk ShotaAk added Type: CI Changes to CI configuration files and scripts Type: Documentation Documentation only changes labels May 25, 2022
@ShotaAk ShotaAk requested a review from Tiryoh May 25, 2022 08:57
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1箇所だけ提案です。その他は良さそうです。

.github/workflows/industrial_ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Daisuke Sato <tiryoh@gmail.com>
@ShotaAk
Copy link
Contributor Author

ShotaAk commented May 26, 2022

@Tiryoh 提案を取り入れました

@Tiryoh Tiryoh merged commit a482f8a into master May 26, 2022
@Tiryoh Tiryoh deleted the add_industrial_ci branch May 26, 2022 05:56
Copy link
Contributor

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit押す前に先にMergeボタンを押してしまいました。良いと思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Changes to CI configuration files and scripts Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants