Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a typecast for check on purge_page_on_new_comment option for ne… #175

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@jinschoi
Copy link
Contributor

commented Feb 24, 2019

New comments were not purging the post.

Using === for equality comparisons require both operands to be of the same type. Other instances of this and similar checks of integer-type options have the appropriate cast. Missing it here means new comments will not purge the post properly.

@tdtgit

This comment has been minimized.

Copy link

commented Apr 9, 2019

When will this PR appear in a release? Just updated to Nginx Helper 2.0.3 and still didn't fix this issue. @mbtamuli

@jinschoi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Please merge this simple and obvious fix.

@pradeep910 pradeep910 merged commit 229da25 into rtCamp:master Jul 16, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP Ready for review
Details
@pradeep910

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

Thanks @tdtgit and @jinschoi for the contribution. Merged it.

@IvanRF

This comment has been minimized.

Copy link

commented Jul 31, 2019

@pradeep910 any idea on when this fix will be released on a new version? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.