Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard cache key deletion for device type cache purge #203

Merged
merged 2 commits into from Jul 1, 2019

Conversation

@pradeep910
Copy link
Collaborator

@pradeep910 pradeep910 commented Apr 26, 2019

Adds wildcard check to delete device type cache such as <URL>--*.

This requires following filter as URLs will not contain --* by default.

add_filter( 'rt_nginx_helper_purge_url', function( $url ) {
       // Add wildcard in cache key URL for all device type keys deletion.
       $url = $url . '--*';
       return $url;
});

For #202

admin/class-phpredis-purger.php Outdated Show resolved Hide resolved
admin/class-phpredis-purger.php Show resolved Hide resolved
admin/class-phpredis-purger.php Show resolved Hide resolved
admin/class-phpredis-purger.php Outdated Show resolved Hide resolved
admin/class-predis-purger.php Outdated Show resolved Hide resolved
@pradeep910 pradeep910 requested a review from chandrapatel Apr 26, 2019
@radhe
Copy link

@radhe radhe commented May 27, 2019

@kirtangajjar @th3karkota
can you do the testing?

@pradeep910 pradeep910 merged commit a871cd4 into master Jul 1, 2019
1 check passed
@pradeep910
Copy link
Collaborator Author

@pradeep910 pradeep910 commented Jul 1, 2019

We've merged this plugin after testing it on one of our live sites.
cc @chandrapatel @kirtangajjar @radhe

@thrijith thrijith deleted the feature/add-wildcard-keys-deletion branch Jul 31, 2019
@thrijith thrijith mentioned this pull request Jul 31, 2019
@pradeep910 pradeep910 mentioned this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants