Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes phpcs errors and warnings #225

Merged
merged 4 commits into from Dec 23, 2019
Merged

Fixes phpcs errors and warnings #225

merged 4 commits into from Dec 23, 2019

Conversation

@chandrapatel
Copy link
Collaborator

chandrapatel commented Dec 23, 2019

No description provided.

@chandrapatel chandrapatel requested a review from thrijith Dec 23, 2019
Copy link
Member

thrijith left a comment

@chandrapatel minor query with JS files.

phpcs.xml Outdated Show resolved Hide resolved
Co-Authored-By: Thrijith Thankachan <thrijith13@gmail.com>
@chandrapatel

This comment has been minimized.

Copy link
Collaborator Author

chandrapatel commented Dec 23, 2019

@chandrapatel minor query with JS files.

@thrijith I have committed suggested changes.

Whitelist and ignore `append` usage in JS
@chandrapatel chandrapatel merged commit c3632f5 into master Dec 23, 2019
1 check passed
1 check passed
WIP Ready for review
Details
@chandrapatel chandrapatel deleted the fix/phpcs-issues branch Dec 23, 2019
@chandrapatel chandrapatel mentioned this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.