Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to fire purge_all for any caching type #232

Merged
merged 2 commits into from Feb 21, 2020
Merged

Add hook to fire purge_all for any caching type #232

merged 2 commits into from Feb 21, 2020

Conversation

Julien-prrs
Copy link
Contributor

@Julien-prrs Julien-prrs commented Feb 13, 2020

Adding this hook allow to call a function after purge_all was called without distinction between FastCGI, Redis or Predis.

@chandrapatel
Copy link
Collaborator

@chandrapatel chandrapatel commented Feb 17, 2020

Hi @Julien-prrs

Thanks for the PR.

Can you please tell me the use case of this new action?

Also, there are actions for FastCGI and Redis cache which executed after purging all cache.

Thanks,
Chandra

@Julien-prrs
Copy link
Contributor Author

@Julien-prrs Julien-prrs commented Feb 18, 2020

Hi @chandrapatel !

Thanks for considering my PR,

As I said in the commit description, it allows us to handle the purge_all without having to handle the FastCGI and Redis by having two differents action to handle.

It's just a simpler way to handle this action in the case where we don't need to target specifically one of them. Having the ability to handle them separately is a really good thing, but for me, in the most cases it's more interesting to fire a single action that handles both types of caching, and if necessary handling one of them more specifically.

@chandrapatel
Copy link
Collaborator

@chandrapatel chandrapatel commented Feb 20, 2020

Hi @Julien-prrs

Thanks for the reply. I have left one feedback. Once it's addressed, I'll merge the PR.

Thanks,

@Julien-prrs
Copy link
Contributor Author

@Julien-prrs Julien-prrs commented Feb 20, 2020

Hi @chandrapatel,

I've just updated my latest commit for matching with your feedback!

Thanks

@chandrapatel
Copy link
Collaborator

@chandrapatel chandrapatel commented Feb 21, 2020

Hi @Julien-prrs

Thanks for addressing the feedback. I have approved the PR and merged.

@chandrapatel chandrapatel merged commit bca38c4 into rtCamp:master Feb 21, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants