Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PHPCS review #3

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kirtangajjar
Copy link
Collaborator

kirtangajjar commented Mar 25, 2019

No description provided.

kirtangajjar added some commits Mar 25, 2019

@rtBot
Copy link

rtBot left a comment

phpcs scanning turned up:

🚫 2 errors


hashes-api-scanning skipped

// And then randomly choose a line
return wptexturize( $lyrics[ mt_rand( 0, count( $lyrics ) - 1 ) ] );
// And then randomly choose a line

This comment has been minimized.

Copy link
@rtBot

rtBot Mar 25, 2019

🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).

@@ -49,15 +49,18 @@ function hello_dolly_get_lyric() {
Promise, you'll never go away
Dolly'll never go away again";
// Here we split it into lines
$lyrics = explode( "\n", $lyrics );
// Here we split it into lines

This comment has been minimized.

Copy link
@rtBot

rtBot Mar 25, 2019

🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.