Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exit of node bidding agent #21

Merged
merged 1 commit into from
Apr 30, 2013

Conversation

dohse
Copy link
Contributor

@dohse dohse commented Apr 17, 2013

No description provided.

@EricRobert
Copy link
Contributor

Hello,

This is what I get:

./rtbkit/js/bidding_agent_js.cc: In static member function ‘static v8::Handlev8::Value Datacratic::JS::BiddingAgentJS::start(const v8::Arguments&)’:
./rtbkit/js/bidding_agent_js.cc:242:20: error: too few arguments to function ‘void ev_ref(ev_loop_)’
/home/recoset/local/include/node/uv-private/ev.h:632:6: note: declared here
./rtbkit/js/bidding_agent_js.cc: In lambda function:
./rtbkit/js/bidding_agent_js.cc:248:26: error: too few arguments to function ‘void ev_unref(ev_loop_)’
/home/recoset/local/include/node/uv-private/ev.h:633:6: note: declared here

I had to add the 'loop' parameter e.g.

struct ev_loop * loop = ev_default_loop(0);
ev_ref(loop);
...

But otherwise, it seems to work. You're probably using a newer version of node.
Can you update your code please and I'll be able to merge.

Thanks!

Éric

EricRobert added a commit that referenced this pull request Apr 30, 2013
Prevent exit of node bidding agent
@EricRobert EricRobert merged commit d5b07cc into rtbkit:master Apr 30, 2013
wsourdeau added a commit that referenced this pull request Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants