Skip to content

/manipulateWidget

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle shiny tag objects with HTML dependencies. #47

Merged
merged 3 commits into from Jan 30, 2018
Merged

Handle shiny tag objects with HTML dependencies. #47

merged 3 commits into from Jan 30, 2018

Conversation

@dmurdoch
Copy link
Contributor

dmurdoch commented Jan 17, 2018

This is a fix for #46. The problem was that the crosstalk::filter_slider object was not a widget, but had HTML dependencies.
Duncan Murdoch
Handle shiny tag objects with HTML dependencies.
Loading status checks…
d626b1c
@dmurdoch dmurdoch mentioned this pull request Jan 17, 2018
Closed
Duncan Murdoch and others added 2 commits Jan 22, 2018
Duncan Murdoch
Also need to look for dependencies in the header, footer, etc.
Loading status checks…
7267b51
@dmurdoch
Add myself as contributor.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
094ba31
@bthieurmel bthieurmel merged commit 29d6bfb into rte-antares-rpackage:master Jan 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmurdoch dmurdoch deleted the dmurdoch:master branch Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dmurdoch @bthieurmel
You can’t perform that action at this time.