/readthedocs.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project import doesn't open import form with FF on OSX #1773

Closed
hackebrot opened this Issue Oct 19, 2015 · 10 comments

Comments

Assignees

@agjohnson agjohnson

Labels
Bug
Projects
None yet
Milestone
No milestone
6 participants
@hackebrot @agjohnson @agronholm @str4d @waveform80 @ericholscher
@hackebrot

hackebrot commented Oct 19, 2015

Hi there!

I am trying to import a new project to rtfd at Import a Repository. For some reason pressing named button doesn't seem to do anything. I am not getting any errors or success messages.

This would be the project I'd like to import https://github.com/hackebrot/pytest-cookies and my account is hackebrot. Any help is greatly appreciated. 🙇

Thank your for your great work! I ❤️ readthedocs
@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Oct 19, 2015

Contributor

Which button are you referring to? If it's what I think it is, the old javascript and css might be cached still, and just requires a refresh. If that's not it, are you receiving any javascript errors on your console when clicking the import button?
Contributor

agjohnson commented Oct 19, 2015

Which button are you referring to? If it's what I think it is, the old javascript and css might be cached still, and just requires a refresh. If that's not it, are you receiving any javascript errors on your console when clicking the import button?

@agjohnson agjohnson added the Support label Oct 19, 2015

@hackebrot

This comment has been minimized.

Show comment
Hide comment
@hackebrot

hackebrot Oct 19, 2015

Talking about the + button on the very right.

screen shot 2015-10-19 at 23 07 10

Refreshing didn't seem to help and the javascript console doesn't report any errors apparently.

screen shot 2015-10-19 at 23 14 13

hackebrot commented Oct 19, 2015

Talking about the + button on the very right.

screen shot 2015-10-19 at 23 07 10

Refreshing didn't seem to help and the javascript console doesn't report any errors apparently.

screen shot 2015-10-19 at 23 14 13
@agjohnson

This comment has been minimized.

Show comment
Hide comment
@agjohnson

agjohnson Oct 19, 2015

Contributor

Ah okay, that wasn't what I thought it was then. This looks like Firefox on OSX, I've confirmed the same behavior there. This looks like a bug with the JS that submits the form.
Contributor

agjohnson commented Oct 19, 2015

Ah okay, that wasn't what I thought it was then. This looks like Firefox on OSX, I've confirmed the same behavior there. This looks like a bug with the JS that submits the form.

@agjohnson agjohnson changed the title from Problem with *import* button to Project import doesn't open import form with FF on OSX Oct 19, 2015

@agjohnson agjohnson added Bug and removed Support labels Oct 19, 2015

@hackebrot

This comment has been minimized.

Show comment
Hide comment
@hackebrot

hackebrot Oct 19, 2015

Yeah sorry about missing out my specs. OS X 10.10.5 Firefox 41.0.2 😶

hackebrot commented Oct 19, 2015

Yeah sorry about missing out my specs. OS X 10.10.5 Firefox 41.0.2 😶
@hackebrot

This comment has been minimized.

Show comment
Hide comment
@hackebrot

hackebrot Oct 19, 2015

Works just fine on Safari 9.0

hackebrot commented Oct 19, 2015

Works just fine on Safari 9.0
@agronholm

This comment has been minimized.

Show comment
Hide comment
@agronholm

agronholm Nov 6, 2015

Contributor

Firefox 42 on Ubuntu 15.10. No errors in console but pressing the button does nothing.
Contributor

agronholm commented Nov 6, 2015

Firefox 42 on Ubuntu 15.10. No errors in console but pressing the button does nothing.

@agjohnson agjohnson referenced this issue Jan 6, 2016

Closed

Project import not working #1900

@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Jun 19, 2016

Same issue with FIrefox 47 on WIndows 7.

str4d commented Jun 19, 2016

Same issue with FIrefox 47 on WIndows 7.
@str4d

This comment has been minimized.

Show comment
Hide comment
@str4d

str4d Jun 19, 2016

Works fine on Chrome 51.0.2704.103 m on the same Windows 7 machine.

str4d commented Jun 19, 2016

Works fine on Chrome 51.0.2704.103 m on the same Windows 7 machine.
@waveform80

This comment has been minimized.

Show comment
Hide comment
@waveform80

waveform80 Aug 19, 2016

Same issue with Firefox 48 on Ubuntu 16.04 (no errors in console, the javascript event seems to be in place, but clicking the button does nothing); seems happy under Chrome 52 on the same platform.

waveform80 commented Aug 19, 2016

Same issue with Firefox 48 on Ubuntu 16.04 (no errors in console, the javascript event seems to be in place, but clicking the button does nothing); seems happy under Chrome 52 on the same platform.

@agjohnson agjohnson referenced this issue Nov 1, 2016

Closed

Clicking the [+] button in the dashboard import has no effect #2393

agjohnson added a commit that referenced this issue Nov 1, 2016

@agjohnson
Fix Firefox import project bug 
Firefox is particular about how a form element can submit. It requires the form
to have a button and to be added to the body of the document.

Fixes #1773
Loading status checks…
575f0f1

@agjohnson agjohnson referenced this issue Nov 1, 2016

Merged

Fix Firefox import project bug #2484

@agjohnson agjohnson self-assigned this Nov 1, 2016

@agjohnson agjohnson added the PR: ready for review label Nov 1, 2016

@ericholscher ericholscher closed this in #2484 Nov 1, 2016

@ericholscher ericholscher removed the PR: ready for review label Nov 1, 2016

ericholscher added a commit that referenced this issue Nov 1, 2016

@agjohnson @ericholscher
Fix Firefox import project bug (#2484) 
Firefox is particular about how a form element can submit. It requires the form
to have a button and to be added to the body of the document.

Fixes #1773
65a522d
@hackebrot

This comment has been minimized.

Show comment
Hide comment
@hackebrot

hackebrot Nov 1, 2016

Thank you for fixing this! 😄 👍

hackebrot commented Nov 1, 2016

Thank you for fixing this! 😄 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment