New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize search phrases/multiple words as AND, not OR #2457

Closed
barbara-sfx opened this Issue Oct 12, 2016 · 9 comments

Comments

@barbara-sfx
Copy link
Contributor

barbara-sfx commented Oct 12, 2016

Details

I'm not sure if this is an issue or a feature request.

  • Project URL: docs.signalfx.com
  • Build URL (if applicable):
  • Read the Docs username (if applicable):

Step:
Search for "metric proxy" (including the quotes)

Actual Result

All docs containing either or both words are returned. We have the word "metric" on many many pages, so these results really don't help.

Expected Result

Ideal: Only pages containing the exact phrase "metric proxy" are returned.
Better than now but not ideal: Only pages with both words are returned

In general, if a search phrase has multiple words, without quotes, I think this should be interpreted as a boolean AND, so only pages containing both words should be returned.

@austin-plixer

This comment has been minimized.

Copy link

austin-plixer commented May 18, 2018

Our company is looking for this feature request as well. It would be very helpful to our readers to search a phrase.

Even if that meant wrapping the search string with quotes as a workaround, it would greatly improve the search feature.

@safwanrahman safwanrahman added this to Backlog in Search update via automation May 21, 2018

@ericholscher ericholscher moved this from Backlog to Up next in Search update Jun 15, 2018

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Jun 15, 2018

I'd like to get this as one of the next steps in our Summer of Code project (https://github.com/orgs/rtfd/projects/3). Having the ability to search with quotes and other common "google style" search queries would be a really good improvement for our search.

@safwanrahman safwanrahman self-assigned this Jun 19, 2018

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Jun 19, 2018

So, this feature should:

  • Allow searching of exact terms ("run the tests" and not return results that just mention tests)
  • It should search in a case insensitive manner ("Run the Tests" should return run the tests)
@barbara-sfx

This comment has been minimized.

Copy link
Contributor Author

barbara-sfx commented Jun 20, 2018

Can linking to a heading above the search term rather than just the top of the doc also be part of the summer of code? (Your link to projects above is 404 so I can't see what's already there.)

@safwanrahman

This comment has been minimized.

Copy link
Member

safwanrahman commented Jun 20, 2018

@barbara-sfx The project has been made public. You will be able to access it now.

@barbara-sfx

This comment has been minimized.

Copy link
Contributor Author

barbara-sfx commented Jun 20, 2018

Thanks @safwanrahman. How would I create a feature request for you guys to prioritize and determine if/when you might address it? Ideally, clicking on a search result would go to the actual matching sentence. I said heading (in my comment above) because I thought that would be more do-able. But navigating to the actual sentence or paragraph is actually what I would expect to see when I click a search result.

@safwanrahman

This comment has been minimized.

Copy link
Member

safwanrahman commented Jun 20, 2018

@barbara-sfx You can create new issue for any feature you would like to get implemented. For taking our attention, you can mention me in the issue, so I can look into it and assign proper flag.
Its better to keep this issue focused on the topic

@safwanrahman safwanrahman moved this from Up next to In progress in Search update Jun 21, 2018

ericholscher added a commit that referenced this issue Jun 26, 2018

Merge pull request #4292 from safwanrahman/exact_match
[Fix #2457] Implement exact match search
@safwanrahman

This comment has been minimized.

Copy link
Member

safwanrahman commented Jun 27, 2018

It has been fixed by #4292
Thanks a lot @barbara-sfx for the issue!
Wishing for the best to get it deployed.

Search update automation moved this from In progress to Done Jun 27, 2018

@safwanrahman

This comment has been minimized.

Copy link
Member

safwanrahman commented Jun 27, 2018

@austin-plixer It has been fixed in the search_upgrade branch. We hope to get it deployed within couple of weeks.

safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this issue Jul 16, 2018

safwanrahman added a commit to safwanrahman/readthedocs.org that referenced this issue Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment