Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Contents jumping #4474

Closed
skaller opened this issue Aug 5, 2018 · 1 comment
Closed

Table of Contents jumping #4474

skaller opened this issue Aug 5, 2018 · 1 comment
Labels
Improvement Minor improvement to code

Comments

@skaller
Copy link

skaller commented Aug 5, 2018

Details

Using a vertically constrained browser window:

(1) Please open https://felix.readthedocs.io/en/latest/expressions.html
(2) Scroll down the left margin TOC and click on "Qualified Names"
(3) The TOC jumps back to the top
(4) To select the next entry from the TOC, one has to scroll down each time

Expected Result

The TOC shouldn't move in this case.

Actual Result

The TOC jumped.

BUG2

When I scroll the document text, the TOC scrolls too. The TOC should not move.
The TOC should be in an independent window. In fact scrolling the TOC also
scrolls the text pane.

Solution

The wrong HTML positioning attributes are being used. The TOC window
should be locked onto the side of the browser window. It should use
CSS position: fixed.

@stsewd stsewd added the Improvement Minor improvement to code label Aug 17, 2018
@agjohnson
Copy link
Contributor

This is a regression, automatic scrolling was already part of the navigation menu. This is a theme issue either way though. I'll move this issue into our theme tracker.

I don't recall if we have a scrolling option on our theme, but if not, you can change this with CSS. The theme is meant to scroll in this behavior however, so this is not buggy behavior. We won't be using fixed positioning for the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants