SearchView and instant search refactor #186

merged 13 commits into from Mar 15, 2012


None yet

3 participants

Nagyman commented Mar 14, 2012


  • Replaced the Haystack SearchView with a Django Class Based View for customization (core.views.SearchView).
  • Use django-pagination for search results
  • Project filtering moved above the search results; displayed inline-block to save space
  • Preserve selected project filters between keyword searches

Instant Search

  • Rewrote the instant search javascript (idiomatic, in a closure, readability, etc)
  • Instant search is not so "instant" anymore; it has a timed delay and checks for actual query changes (not just responding to every key press). Should ease hammering of servers and the browser won't be inundated with ignored responses.
  • Instant search uses replaceState (when supported) to update the URL

... next up, putting project results back in (they're missing with the instant search).


Awesome. I'm at the real job today, but I'll take a look at this tonight. Thanks!

@ericholscher ericholscher merged commit 315a048 into rtfd:master Mar 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment