New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CDN code to external abstraction #2091

Merged
merged 6 commits into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@agjohnson
Contributor

agjohnson commented Mar 25, 2016

This adds a signal for listening as an external application, purging can be
performed on a project basis there.

agjohnson added some commits Mar 25, 2016

Move CDN code to external abstraction
This adds a signal for listening as an external application, purging can be
performed on a project basis there.
@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 25, 2016

This should remove the CDN code from inside RTD, as well.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Mar 25, 2016

Forgot that, updated.

@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 25, 2016

Guessing this is blocked on deployment as well? Looks good otherwise.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Mar 25, 2016

It shouldn't on the community site at least, as there aren't any cdn users configured

@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 26, 2016

Ah, True.

@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 28, 2016

👍 on merging re: conversation above.

@berkerpeksag

This comment has been minimized.

Member

berkerpeksag commented Jul 15, 2016

It seems like the 'maxcdn' entries in tox.ini and requirements/deploy.txt are not needed.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Jul 16, 2016

Need to get back to this and rebase, will need to double check that the pieces we need are in the extension + operations provisioning.

Marked as blocking for now

@agjohnson agjohnson self-assigned this Oct 4, 2016

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Feb 27, 2017

This is now unblocked and should be cleaned up.

@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 6, 2017

@agjohnson anything specifically that needs to be cleaned up? I don't believe we currently have an CDN users, so this would be a good time to get it merged.

ericholscher added some commits Mar 6, 2017

@ericholscher

This comment has been minimized.

Member

ericholscher commented Mar 31, 2017

@agjohnson I'd be +1 on merging this now since we don't have any current CDN users, and we can confirm it works on the next setup we do.

@humitos

This comment has been minimized.

Member

humitos commented Mar 23, 2018

@agjohnson is there anything else we need to do here?

It seems that we remove the purge function and now it's triggering a signal, but the signal is not connected --so, the old purge function / code is not being executed.

@ericholscher ericholscher merged commit 3fc3c15 into master Jun 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@stsewd stsewd deleted the cdn-abstraction branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment