Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

corrected the support for selecting from multiple python interpreters #330

Merged
merged 3 commits into from Mar 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

yeiniel commented Jan 18, 2013

In the last pull request made by me a bug was introduced: the new feature require that the virtualenv module was installed in every python interpreter. This problem is easily detected reading the log of documentation build process for projects that use this options (like one i have). This pull request solve this by using an existing functionality of the virtualenv command that allow the definition of the python interpreter to use in a new virtual environment. This feature allow the use of the virtualenv installed in the machine as command no matter the interpreter it use.

I hope this is the final solution, best regards
Yeiniel

@yeiniel yeiniel commented on the diff Jan 18, 2013

readthedocs/projects/tasks.py
@@ -304,7 +304,7 @@ def update_imported_docs(version_pk):
# Here the command has been modified to support different
# interpreters.
update_docs_output['venv'] = run('{cmd} --distribute {site_packages} {path}'.format(
- cmd='{interpreter} -m virtualenv'.format(
+ cmd='virtualenv -p {interpreter}'.format(
@yeiniel

yeiniel Jan 18, 2013

Contributor

this little change remove the need of the virtualenv module installed on different interpreters in the same host.

ericholscher added a commit that referenced this pull request Mar 1, 2013

Merge pull request #330 from yeiniel/master
corrected the support for selecting from multiple python interpreters

@ericholscher ericholscher merged commit 96b3865 into rtfd:master Mar 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment