New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where you couldn't edit your canonical domain. #3387

Merged
merged 4 commits into from Dec 18, 2017

Conversation

Projects
None yet
2 participants
@ericholscher
Member

ericholscher commented Dec 8, 2017

This logic was checking to see if the domain passed in was the current canonical,
but using the domain you were trying to change it to.
We should be checking for the existing PK to see if you're editing,
not the new domain.

Fixes #2922

Fix issue where you couldn't edit your canonical domain.
This logic was checking to see if the domain passed in was the current canonical,
but using the domain you were _trying_ to change it to.
We should be checking for the existing PK to see if you're editing,
not the new domain.

@ericholscher ericholscher requested review from humitos and agjohnson Dec 11, 2017

@agjohnson

LGTM. Perhaps we need a test to ensure the bug is fixed and we're using the form in the correct way now?

@ericholscher ericholscher merged commit 14adb20 into master Dec 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@stsewd stsewd deleted the fix-domain-editing branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment