New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display the build suggestions div if there are no suggestions #3389

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
3 participants
@agjohnson
Contributor

agjohnson commented Dec 8, 2017

This added extraneous spacing to the build page.

@agjohnson agjohnson requested a review from ericholscher Dec 8, 2017

<p>
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
{% blocktrans %}
Don't want <pre>setup.py install</pre> called?

This comment has been minimized.

@humitos

humitos Dec 11, 2017

Member

This tag was changed to em

@ericholscher

What manuel said, needs the em. Otherwise looks good.

Don't display the build suggestions div if there are no suggestions
This added extraneous spacing to the build page.
@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Dec 14, 2017

Rebased.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Dec 14, 2017

Error is fixed in #3402

@agjohnson agjohnson merged commit 2bdc987 into master Dec 14, 2017

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@agjohnson agjohnson deleted the agj/remove-empty-build-idea branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment