New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog more consistently #3405

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
3 participants
@agjohnson
Contributor

agjohnson commented Dec 14, 2017

  • Get the last modified date from git, not local file as normally expected
  • Make sure we're on master to run
  • Don't do reset to master on release
Update changelog more consistently
* Get the last modified date from git, not local file as normally expected
* Make sure we're on master to run
* Don't do reset to master on release
@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Dec 14, 2017

More unrelated errors

# Get last modified date from Git instead of assuming the file metadata is
# correct. This can change depending on git reset, etc.
git_log = ctx.run('git log -1 --format="%ad" -- CHANGELOG.rst')
last_modified = parse(git_log.stdout.strip()).strftime('%Y-%m-%d')

This comment has been minimized.

@ericholscher

ericholscher Dec 14, 2017

Member

We should put a note in the changelog that it's auto-generated, and not to touch it manually.

This comment has been minimized.

@agjohnson

agjohnson Dec 14, 2017

Contributor

Actually, one of the benefits of this tool is that it only updates the changelog for last release. It does allow for authoring in between generating and commiting, so we can add deployment and migration notes, or more general description of some of the changes

@agjohnson agjohnson merged commit f1087d3 into master Dec 15, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the agj/more-invoke-changes branch Dec 15, 2017

# Ensure we're on the master branch first
git_rev_parse = ctx.run('git rev-parse --abbrev-ref HEAD', hide=True)
current_branch = git_rev_parse.stdout.strip()
if current_branch != 'rel':

This comment has been minimized.

@humitos

humitos Dec 15, 2017

Member

why rel here? shouldn't be master?

I mean, it checks if we are in rel and if not, it says "hey, you need to be on master"

Other, we want to ensure we are on rel not on master, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment