New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concept of dashboard analytics code #3420

Merged
merged 5 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@ericholscher
Member

ericholscher commented Dec 18, 2017

This lets us have a specific Analytics code for the dashboard, instead of
using it for dashboard & docs. This keeps the pre-existing global one for
all things, but lets us segment out the dashboard.

This is mainly useful for having GA not sample our dashboard traffic, so we
can get real data for it.

ericholscher added some commits Dec 14, 2017

Add concept of dashboard analytics code
This lets us have a specific Analytics code for the dashboard,
instead of using it for dashboard & docs.
This keeps the pre-existing global one for all things,
but lets us segment out the dashboard.

This is mainly useful for having GA not sample our dashboard traffic,
so we can get real data for it.

@ericholscher ericholscher requested review from humitos and agjohnson Dec 18, 2017

ericholscher added some commits Dec 18, 2017

@agjohnson

Looks good 👍

@@ -312,7 +312,8 @@ def INSTALLED_APPS(self): # noqa
STRIPE_PUBLISHABLE = None
# Misc application settings
GLOBAL_ANALYTICS_CODE = 'UA-17997319-1'

This comment has been minimized.

@agjohnson

agjohnson Dec 19, 2017

Contributor

Ah this is probably what i was thinking of in the related ops PR.

@ericholscher ericholscher merged commit 6fd8282 into master Dec 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@agjohnson agjohnson deleted the support-dashboard-analytics-code branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment