New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack in a fix for missing version slug deploy that went out a while back #3433

Merged
merged 2 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@ericholscher
Member

ericholscher commented Dec 21, 2017

Also has some updates to symlink command, so we can properly rebuild web05 without running out of memory.

@@ -75,6 +75,10 @@ def footer_html(request):
subproject = request.GET.get('subproject', False)
source_suffix = request.GET.get('source_suffix', '.rst')
# Hack in a fix for missing version slug deploy that went out a while back
if version_slug == '':
version_slug = 'latest'

This comment has been minimized.

@humitos

humitos Dec 21, 2017

Member

Maybe this is better,

if not version_slug:
    version_slug = LATEST

The "linting" guy :)

This comment has been minimized.

@ericholscher

ericholscher Dec 21, 2017

Member

We actually want to check it being an empty string, not None, because that is the error I'm catching.

@ericholscher ericholscher merged commit 5901dcb into master Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the hotfix-verison-slug-hack branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment