New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show link to docs on a build #3446

Merged
merged 3 commits into from Mar 23, 2018

Conversation

Projects
None yet
5 participants
@stsewd
Member

stsewd commented Dec 23, 2017

This PR is related to #3398 and #2469

For now, I trying to solve this:

If we're on a build, use the build version for the view docs link! This gets me every time

I think the View Docs button must remain the same on all the project area, otherwise it would be confusing.

I don't know much css, so any feedback is more than welcome :).

Here is how it looks right now

build-fail
build-progress
build-success

And how it will looks like after merging

build-fail
build-progress
build-success

This is still very WIP, so any feedback and suggestion is welcome!

Build #{{ build_id }}
{% endblocktrans %}
</span>

This comment has been minimized.

@stsewd

stsewd Dec 23, 2017

Member

I don't know how to do this on a better way, what js library are you using?

This comment has been minimized.

@ericholscher

ericholscher Dec 28, 2017

Member

Knockout I believe.

@stsewd

This comment has been minimized.

Member

stsewd commented Dec 23, 2017

Hope I didn't break any other parts with the css change.

@ericholscher

Looks good to me in local testing. Will let @agjohnson comment on the HTML/JS stuff.

Build #{{ build_id }}
{% endblocktrans %}
</span>

This comment has been minimized.

@ericholscher

ericholscher Dec 28, 2017

Member

Knockout I believe.

@humitos

This comment has been minimized.

Member

humitos commented Dec 29, 2017

This is a very personal opinion and so probably not that relevant

I think that with this change we are loosing some visual strengh impact on the status of the build when changing the red/green square by colorizing just the text Build #111 with red/green.

I'd like to have the link view docs next to the old green square, instead of changing the structure.

Something like this:

my

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Jan 5, 2018

Visually, I prefer the change that @humitos suggests as well.

Alternatively, the view docs link would also fit in the right float area nicely. My vote would be for adding the link to this section.

My original thought is that we'd repurpose the main View Docs button, as it is really confusing that it always points to the same branch. This is another option.

@agjohnson

From the technical side, these changes looks good 👍

The changes to revert the styling to the old UI will likely revert a lot of these additions however.

@stsewd

This comment has been minimized.

Member

stsewd commented Jan 9, 2018

I reverted the other changes and put the link to the right as @agjohnson suggest

On building state

1

No staff user

3

Staff user

2

@humitos

humitos approved these changes Jan 9, 2018

I like this new proposal!

@agjohnson agjohnson merged commit 2d6d2a0 into rtfd:master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the stsewd:show-link-to-docs branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment