Join GitHub today
Remove our mkdocs search override #3496
This removes the JSON build on mkdocs,
It will fix the error here: http://readthedocs.org/projects/mkdocs/builds/6503359/
It also fixes the search so that it uses mkdocs builtin search, instead of our own broken search for mkdocs. This is a temporary fix, but will at least make search work.
changed the title from
Stop running Mkdocs JSON builder
Remove our mkdocs search override
Jan 9, 2018
LGTM. I just left a minor comment. Check the conflicts on the js file.
I didn't test the mkdocs builtin search (not the search itself, but that the url of the form is correct for example). I suppose that you did and work :)
This is a temporary fix, but will at least make search work.
We should create an issue to track this: go back to our better mkdocs search engine, at some point.
Yes, I understand that but if their own search doesn't work either I think it's preferable to remove the search completely from mkdocs to avoid another tons of issues. El 11 ene. 2018 11:15 a. m., "Eric Holscher" <email@example.com> escribió: There's already a million tickets about mkdocs search not being great. They removed the json command that we were using for search on our side, so I'm not sure if "proper" search for mkdocs is in the cards. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO7sECtXrTHlvrmZ_3pqHJg4nbD6Dwvks5tJjOKgaJpZM4RYdB8> .
Their own search works fine, thats what this PR is for :) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3496 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO7sBM4EuY2OyzOF6O6pTCgnqGvJXoJks5tJj1MgaJpZM4RYdB8> .