Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Consistent version format #3504
This closes #2357
The js, didn't break because of some weird js implicit cast.
var currentURL = window.location.pathname.replace('rtfd', ['hi']) console.log(currentURL) // This works!
So, I'd say that we need to fix our Python tests for this, make some manual QA on different pages to see how the JS is affected and check that everything continue working and finally ask @agjohnson or @ericholscher if this won't blow up something else :)
Not sure how to know this, though. So, maybe you know better :)
The footer API is an internal API, so it should be OK to change how it works, as long as the client code changes too.
The main tricky thing with JS is that sometimes we are shipping the JS with each build, so we have to support older versions with embedded JS. This client code comes from the server though, so I think this change should be
The best way to test this is to build a local docset with