New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline reset to bring back outline #3512

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
4 participants
@kennethlarsen
Contributor

kennethlarsen commented Jan 13, 2018

This PR removes the outline reset for the main site.

This is needed to improve accessibility of the site. Outline is much needed for a lot of keyboard-only users and should not be removed. It's only allowed to be reset if you actually restyle it.

Read more: http://www.outlinenone.com/

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Jan 15, 2018

Thanks! I've been wanting to make this change as well. This probably needs some QA, but I don't think there will be any major problems that get raised with the change.

@ericholscher

This comment has been minimized.

Member

ericholscher commented May 30, 2018

Looked at this locally and it looks good. It's actually much nicer to use tab on the site.

@ericholscher ericholscher merged commit 041477a into rtfd:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kennethlarsen kennethlarsen deleted the kennethlarsen:feature/enable-outline branch Jun 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment