Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow git tags with `/` in the name and properly slugify #3545
@stsewd I think what you mentioned is probably another issue.
I mean, there two things here:
It seems that some time ago, we weren't using
Anyway, thanks to your comment I found that the
Will this cause existing versions to be deleted and re-created? What happens with existing active versions that would be "re-tagged"? This should likely include a data migration, as with all changes to our slugging, but that will also breaking existing URL's to active versions, so we'll likely need redirects too.
I don't think so. We are using
I suppose that this won't happen.
A couple of things here:
So, I'd say that it's safe to merge this PR but I would like to know if my thoughts are right and write a couple of tests with the scenario described in the bullets. What do you think? Do you see any other case that I'm not considering?
Yea. I see how this is a better approach. I still worry it will cause active versions that came from the pre-existing broken names to not be updated properly.
Was there a bug where we weren't properly updating these versions because the post-commit logic was parsing them properly, but the VCS code wasn't?
Jan 30, 2018
1 check passed
I'm not 100% sure to understand your comments, but
Mmm... Yes. This won't be updated automatically. The sync versions is not too aggressive and do nothing if the identifier doesn't change but, what we can do here? I'm not sure how to fix already broken names.