Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use DRF 3.1 `pagination_class` #3559
@ericholscher @agjohnson since we were talking that mixing style and logic PR is kind of tedious, I created another PR based on this where I ran
Let me know if you like this approach. It a little tedious to make two different PR but I hope it simplies the review.
@safwanrahman good catch!
I think it's a good idea. I'd like to fix the bug and make it work as it was working before since it could be other places that use that endpoint and may rely on that pagination size also.
Yes, we should think in a non-intrusive UI design for this. Most of the users won't have more than 25 organizations (in fact we have just one report of a person having 11 :) ).
But anyway, I agree with both suggestions but I'd like to make them in different PR.
If you agree with me, would you mind openning these two issues? Thanks!