New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for build screen in firefox #3569

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
5 participants
@davidfischer
Contributor

davidfischer commented Feb 1, 2018

This problem is due to the ::-webkit-scrollbar override specifying a scrollbar height and then trying to hide it with a negative margin.

Removing only the negative margin (as in #2350) results in the scrollbar still being allocated 15px extra. Instead removing both the negative margin and the extra scrollbar sizing of webkit of these brings the two browsers into parity. The only difference is that the scrollbar is visible on Firefox (there's no FF equivalent of ::-webkit-scrollbar) but that doesn't impact the usability much.

screen shot 2018-02-01 at 12 07 15 pm

(Chrome 63 in the foreground with Firefox Developer Edition 59 in the background)

@agjohnson

This is a much better fix than just the negative margin fix, I'm glad someone was able to hunt this down. A visible scrollbar isn't the worst thing. Could you post a screenshot of what this looks like?

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented Feb 5, 2018

The scrollbar is only visible while scrolling so it is invisible while a user isn't interacting with the page.
screen shot 2018-02-05 at 8 50 20 am

The scrollbar is visible while scrolling.
screen shot 2018-02-05 at 8 50 26 am

The scrollbar on the command is also visible. This makes it slightly more difficult to click on the command to minimize it after it is already maximized.
screen shot 2018-02-05 at 8 50 30 am

@RichardLitt RichardLitt added the Design label Feb 6, 2018

@ericholscher ericholscher merged commit ee81f28 into rtfd:master Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stsewd

This comment has been minimized.

Member

stsewd commented Feb 12, 2018

@davidfischer on my firefox the scroll bar is always visible

screenshot-2018-2-11 bookpy read the docs

Firefox verison: 58.0.1 (64-bit)
OS: Fedora 27

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented Feb 12, 2018

@stsewd that's odd. I tested on Firefox 58.0.2 (64-bit) on MacOS without issue. I'll see if I can get a virtual machine with Fedora.

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented Feb 12, 2018

@stsewd I see the same as you in Fedora. I didn't realize this but the scrollbars come from the OS. There is a bugzilla issue to allow styling the scrollbars, but I wouldn't hide my breath.

While I suppose the current state is better than it was before this PR this is still unfortunate. Overall, I think this build page simply needs to be retooled a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment