Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
formatting buttons in edit project text editor #3633
Firstly, thank you very much for the first-time contribution!
This does in fact fix the RST editor and it worked for me. However, I had a question about the minified file
Ideally, this plugin should come from bower or NPM but perhaps it's best to merge this PR once we've verified the pack file and then switch to loading it from bower in a separate PR.
Edit: bower or NPM
I'd be +1 on removing it. It's a bunch of code for a small field, which most people will just be copying from a README file or similar.
Sorry to invalidate the work you did @aasis21, but if you could just remove the files, I'd be happy to commit it! Thanks for making the effort, allowing us to have this discussion.
I think this PR should be scaled back to just remove the markitup dependency. We can keep a description field for now. Removing this will be a larger chunk of work and requires us to make a design decision around this. We'll want to review the UI changes that this entails for before just removing.
I've have been wanting to get rid of this field for a long time however. I don't think we need it, or any project description on our dashboard page -- this isn't a page that readers see.
I've opened #3689 for core to discuss removing the field.
I'm glad to get rid of the markitup dependency! For now, let's scale this back to just remove the markitup dependency and once we have more guidance on removing the description field we can work on that.