New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error logging that isn't an error. #3650

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@ericholscher
Member

ericholscher commented Feb 22, 2018

This is clogging up our Sentry instance,
causing us to go over our free allotment.

Remove error logging that isn't an error.
This is clogging up our Sentry instance,
causing us to go over our free allotment.

@ericholscher ericholscher requested review from humitos and davidfischer Feb 22, 2018

@davidfischer

👍

@@ -148,7 +148,7 @@ def commit_name(self):
# If we came that far it's not a special version nor a branch or tag.
# Therefore just return the identifier to make a safe guess.
log.error('TODO: Raise an exception here. Testing what cases it happens')
log.debug('TODO: Raise an exception here. Testing what cases it happens')

This comment has been minimized.

@humitos

humitos Feb 22, 2018

Member

Ups! I introduced this for future research and I never did it :/

@ericholscher ericholscher merged commit 0a4a287 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the remove-error-logs branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment