New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send proper context to celery email notification task #3653

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Feb 22, 2018

This solves an issue in the .com site that we are experimenting.

Although I couldn't get the error report in .org Sentry, I'm not receiving the email on FAILED builds in my .org account either. So, I think this PR will also fix the problem here.

NOTE: by sending the objects as dictionaries we can continue using the templates as they are. Antoher approach could be sending all that data in separate fields like version_verbose_name or project_name and adapting the templates to this.

Ref: rtfd/readthedocs-corporate-ops#77

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Feb 22, 2018

I think this looks good! The context data structure makes sense to me.

I thought we solved this problem here already, but perhaps this was a different email i'm thinking of.

@agjohnson agjohnson merged commit 1b58bed into master Feb 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stsewd stsewd deleted the humitos/notifications/fix branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment