New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always record the git branch command as success #3693

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@humitos
Member

humitos commented Feb 27, 2018

This is causing the build to be marked as FAILED when the repository
has no branches.

Always record the git branch command as success
This is causing the build to be marked as FAILED when the repository
has no branches.

Closes #3644
@humitos

This comment has been minimized.

Member

humitos commented Feb 27, 2018

@stsewd @agjohnson I think I found the issue for #3644. Although, I wasn't able to reproduce it in my local instance (maybe because of the git version. 2.16.2 is mine)

I'm just supposing that git branch -r could be returning a non-zero exit code when no branches (as the comment in the code says) and that is marking the build as FAILED.

Could you help me by testing this PR manually in your local instance and let me know? Thanks!

@stsewd

This comment has been minimized.

Member

stsewd commented Feb 27, 2018

I tested this branch and the master branch; still the issue. But I almost couldn't replicated it on master, I was able to replicated it again wiping and building the version. Although, I think this is just a helper, since I was able to replicate it without wiping, yesterday. I believe is because is only visible when the process is slow, so on faster machines like @humitos is difficult to replicate.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Mar 9, 2018

This doesn't resolve the underlying issue, but this does resolve a separate bug with the build output page. LGTM!

@agjohnson agjohnson merged commit 1edd47a into master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/build/state branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment