Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add eslint rules and fix errors #3726
This PR Fixes #2909.
I have tested for all the rules mentioned in the issue. I have set the rules to
There were 106 errors and warnings. Now we have 0 errors and 31 warnings. All these warnings are false positives.
I would also like to suggest to enforce the following rules:
Firstly, thank you for the first time contribution.
This looks well thought through and well done and I'm happy to see this make it into
I do think your suggestions (especially
Thank you @davidfischer!
Shall I make a separate PR for that?