Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[RDY] Fix tests for environment #3764
changed the title from
Fix tests for environment
[RDY] Fix tests for environment
Mar 14, 2018
Weee! I like all these tests.
Be careful when using the mock library since it's very easy to make mistakes that will pass without raising any exception but in the end we are not testing exactly what we want.
(be sure to rebase your branch to use the latest mock lib --2.0-- since I had the same problem when using
assert_ and the test was passing but it wasn't asserting anything :) )
Please, take a look at the comments that I left and re-check to see if the tests are testing exactly what you want (this code is tricky) and I will review it again after that.
Nice work! This is something that we really need ;)