Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use readthedocs-common to share linting files accross different repos #3808
One minor problem that I see here is that modifying the config files on that repo won't affect inmmediately to the other repos (won't trigger a tox process with the
So, I think we could configure to trigger this once a PR is created in the
I think that is actually a feature of using submodules here. It also allows us to pin to a specific commit in the common branch for each repo, so sudden changes won't automatically affect all repositories.
Hopefully we have things tuned enough now that it won't be too much of a problem though.
The one problem I anticipate with the shared repo is that changes to the common rules will require us to run checks against all of the parent repositories to ensure things don't break horribly. We'll work that out later though