Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update instance and model when `record_as_success` #3831
When we record the command as SUCCESS (exit_code=0) we also need to
This looked as a random failure, but it was happening always that any
I found another edge case:
When we use
So, we have the same problem than I explained in the description: this command is add to the
I just fixed the last edge case that I found.
This PR will need some review since it seems simple and coeherent but its touching an important chunk of code.
Also, the solution proposed here is not the best regarding desing or code style. Although, implementing another solution will take too much refarctoring since we will need to adjust/discuss other concepts probably.
I was able to reproduce the issue on the current master, but on this branch on several build everything looks good!
p.s: kind of I was fixing this on other pr without knowing https://github.com/rtfd/readthedocs.org/pull/3687/files#diff-ca52b098301dd315a834b3556ab9a7d5R363 haha