New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search bar in dashboard have a more clear message. #3844

Merged
merged 2 commits into from May 24, 2018

Conversation

Projects
None yet
5 participants
@ze
Contributor

ze commented Mar 24, 2018

The current search bar in the users dashboard isn't very clear on what its functionality exactly is. The user can assume that it will search inside their projects or some other functionality.

This pull request allows for the search bar to have a more clear functionality.

Update: I should have provided an image to accompany this PR.
screenshot from 2018-03-25 02-56-54

@stsewd

This comment has been minimized.

Member

stsewd commented Mar 25, 2018

This is the search on the project scope

screenshot-2018-3-25 search read the docs

So, shouldn't it say Search in Read the Docs? (I'm not sure if that it's right wording)

@ze

This comment has been minimized.

Contributor

ze commented Mar 25, 2018

My rationale was that since it has the same functionality as the search box at readthedocs.org
screenshot from 2018-03-25 02-38-32 it would be appropriate if it had the same placeholder.

There are a lot of possible choices that can be defended, but this choice made the most sense to me.

I would even propose that we adjust that image you provided by further inspection
(inconsistent coloring with other tabs, semicolon is inconsistent as well, size is an h2 but all other tabs use an h1, etc).

@stsewd

This comment has been minimized.

Member

stsewd commented Mar 25, 2018

Yeah, you are right! Do you want to open a new issue for the other suggested changes?

@ze

This comment has been minimized.

Contributor

ze commented Mar 25, 2018

I'll open one right now, thanks for reviewing my pull request!

@@ -115,7 +115,7 @@ <h3>{% trans "Projects" %}</h3>
<div class="module search search-dashboard">
<form action="{% url 'search' %}" method="GET">
<div class="text-input-wrapper search search-dashboard">
<input type="text" name="q" class="search">

This comment has been minimized.

@xrmx

xrmx Mar 28, 2018

Contributor

Please make the string translatable

This comment has been minimized.

@ze

ze Mar 30, 2018

Contributor

Alright, it's been done!

@ericholscher ericholscher merged commit a103211 into rtfd:master May 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Member

ericholscher commented May 24, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment