Join GitHub today
Send notifications when generic/unhandled failures #3864
This PR used to have a test case but it wasn't accurate. I decided to remove it and leave this small piece of code untested (send an email on unhandled failures). It shouldn't be terrible and it does fix an issue that our customer are having at the moment.
We can improve this later when a re-work is done around the
referenced this pull request
Apr 20, 2018
@ericholscher this isn't just a test. In fact, this solves a problem reported in the corporate site: when a generic exception happens an email is not sent to the user. This PR makes that email/notification to go out properly.
The problem on this PR is that I didn't find a way to write an accurate test because our update task flow exception handling depends on