New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync webhooks from Admin #3933

Merged
merged 1 commit into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Apr 10, 2018

If the user delete the RTD webhook integration for whatever reason from the project under the external service (GitHub, etc) when the Resync button is pressed we re-create / setup the webhook as it was never existed.

This behaviour already existed, but it worth to mention it:

If the user modifies the webhook in the external service (changing the URL for example), when Resync button is pressed, we update it with the proper URL.

Closes #3931

Resync webhooks from Admin
If the user delete the RTD webhook integration for whatever reason
from the project under the external service (GitHub, etc) when the
Resync button is pressed we re-create / setup the webhook as it was
never existed.

@humitos humitos requested a review from rtfd/core Apr 10, 2018

@agjohnson

Oops, yeah we should have been catching a missing webhook here.

LGTM

@humitos humitos merged commit 31661ad into master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@humitos humitos deleted the humitos/integrations/resync branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment