Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add advertising details docs #3955
We get a fair amount of inquiries regarding advertising. These usually take the form of one of:
The goal of this PR is to cover these as much as possible.
Fixes #3952 (mostly)
referenced this pull request
Apr 16, 2018
Please update ethical-advertising.rst as well (see #3952)
To clarify the GA point, maybe change this to something similar to:
The key difference above is the addition of the following to the "we don't track you" point:
Overall I'm -1 on that revision for the following reasons:
Instead I would consider a footnote or possibly a clarifying point in the body that points to the technical details document.
I am fine with putting this (or similar) information somewhere else in the text. I think it should not be a footnote (footnotes have bad reputation in my opinion, especially when it comes to data privacy).
I disagree that GA should not be mentioned in ethical-advertising.rst simply because GA is covered in advertising-analytics already. Once you motivate ethical ads, you should also be transparent to your users regarding the techniques you use. As far as I understood, GA is used to quantify how many clicks an ad (and other things you as developers might be interested in) gets.
Your point on footnotes is fair. However, I think having an entire section in the docs is quite prominent.
I agree with being transparent. That's why we are writing it in the docs. GA is not a secret at Read the Docs. The code is open source and there have been many public issues and pull requests surrounding analytics.
I would classify even the specific analytics implementation ("Google" analytics as opposed to merely "analytics") as an implementation detail. GA can be swapped out but there will always be some sort of analytics even if it is based on log analysis.
This is not the main motivation. We do not rely on Google Analytics for billing advertisers or quantifying clicks. We do fire a GA even for ad clicks but the main reason for that is because GA gives a convenient way to explore that data (do ads perform better on certain themes? certain programming languages? etc.). The primary motivation behind analytics has a paragraph in the new document:
To propose a solution, how about modifying