New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dynamic-fixture to testing requirements #3956

Merged
merged 3 commits into from Apr 29, 2018

Conversation

Projects
None yet
4 participants
@stsewd
Member

stsewd commented Apr 17, 2018

As far as I know, this is only used for testing, also I did a grep on the project and only found imports on test files.

@humitos

This comment has been minimized.

Member

humitos commented Apr 17, 2018

@stsewd can you check the errors on travis, please?

@stsewd

This comment has been minimized.

Member

stsewd commented Apr 17, 2018

@humitos I didn't run the tests for the linter on my local instance, I'm going to see why the package is required by the linter.

@stsewd

This comment has been minimized.

Member

stsewd commented Apr 17, 2018

OK, I found the issue, I'm solving it on rtfd/common#6

@agjohnson agjohnson added this to the Cleanup milestone Apr 17, 2018

@stsewd stsewd referenced this pull request Apr 18, 2018

Merged

Ignore rtd_tests folder #6

@ericholscher

This comment has been minimized.

Member

ericholscher commented Apr 27, 2018

Think this should be unblocked now.

ericholscher and others added some commits Apr 27, 2018

@stsewd

This comment has been minimized.

Member

stsewd commented Apr 28, 2018

I updated the submodule, this is ready :)

@ericholscher ericholscher merged commit 30eabd1 into rtfd:master Apr 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Member

ericholscher commented Apr 29, 2018

👍

@stsewd stsewd deleted the stsewd:move-testing-requirement branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment