New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-celery-beat and use the default scheduler #3959

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Apr 17, 2018

There are some issues with timezone for the DatabaseScheduler, so we fallback to the default one (celery.beat.PersistentScheduler) which is simpler --doesn't allow us to change the scheduled task from the admin, but we don't need that.

In case we need this again, we can come back when those issues are already fixed and revert this commit.

Remove django-celery-beat and use the default scheduler
There are some issues with timezone for the `DatabaseScheduler`, so we
fallback to the default one (celery.beat.PersistentScheduler) which is
simpler --doesn't allow us to change the scheduled task from the
admin, but we don't need that.

In case we need this again, we can come back when those issues are
already fixed and revert this commit.
@humitos

This comment has been minimized.

Member

humitos commented Apr 17, 2018

To test this, you can make minute='*' in one of the already celery scheduled tasks and run celery worker and beat. In the next minute you will see the log in the console that a task was sent

@humitos humitos requested a review from agjohnson Apr 17, 2018

@agjohnson agjohnson added this to the 2.4 milestone Apr 17, 2018

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Apr 17, 2018

LGTM

@agjohnson agjohnson merged commit 907bad3 into master Apr 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@agjohnson agjohnson deleted the humitos/celery/beat-scheduler branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment