New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `resolve_domain` work when a project is subproject of itself #3962

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
5 participants
@humitos
Member

humitos commented Apr 18, 2018

This is an invalid db state since this relationship is not possible, but there are some old project that has this relationship and we want to avoid breaking the code for this cases.

@ericholscher

Looks good.

@humitos

This comment has been minimized.

Member

humitos commented Apr 18, 2018

Mmm... this didn't trigger a travis build.

Make `resolve_domain` work when a project is subproject of itself
This is an invalid db state since this relationship is not possible,
but there are some old project that has this relationship and we want
to avoid breaking the code for this cases.
@humitos

This comment has been minimized.

Member

humitos commented Apr 18, 2018

I just rebased trying to trigger a travis build.

@stsewd

This comment has been minimized.

Member

stsewd commented Apr 18, 2018

@humitos you can restart the build from travis itself.

@davidfischer

This comment has been minimized.

Contributor

davidfischer commented Apr 18, 2018

@stsewd normally you can. However, we looked and couldn't find that option since Travis never triggered a build in the first place.

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Apr 18, 2018

Lint error looks unrelated, I'll force merge.

@agjohnson agjohnson merged commit 3c581d8 into master Apr 18, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@agjohnson agjohnson deleted the humitos/resolver/subproject-itself branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment