New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest setuptools (39.0.1) by default on build process #3967

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@humitos
Member

humitos commented Apr 18, 2018

More info/questions in the issue itself.

Closes #3963

@@ -224,7 +224,7 @@ def install_core_requirements(self):
self.project.get_feature_value(
Feature.USE_SETUPTOOLS_LATEST,
positive='setuptools<40',

This comment has been minimized.

@agjohnson

agjohnson Apr 18, 2018

Contributor

Regarding your question, I'm +1 on pinning <41 on positive so that we're testing as soon as a new backwards incompat package is out.

This comment has been minimized.

@humitos

humitos Apr 18, 2018

Member

If we pin <41 here, what should we do with the 10k project that have already the feature flag? Should we remove this feature from those or should we keep as they are?

It won't be a problem immediately, but it could be an issue when 40 is released... maybe.

@@ -224,7 +224,7 @@ def install_core_requirements(self):
self.project.get_feature_value(
Feature.USE_SETUPTOOLS_LATEST,
positive='setuptools<40',
negative='setuptools==37.0.0',
negative='setuptools==39.0.1',

This comment has been minimized.

@agjohnson

agjohnson Apr 18, 2018

Contributor

Similar, any reason not to just pin <40 here?

This comment has been minimized.

@humitos

humitos Apr 18, 2018

Member

Just wanted to keep the same pinned status we had before, but I'm fine on pinning <40 which seems safe.

@humitos humitos added this to the 2.4 milestone Apr 18, 2018

@agjohnson

This comment has been minimized.

Contributor

agjohnson commented Apr 19, 2018

LGTM

@agjohnson agjohnson merged commit 0efc5e8 into master Apr 19, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@agjohnson agjohnson deleted the humitos/feature/latest-setuptools branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment