Join GitHub today
Allow to hook the initial build from outside #4033
Still WIP, so just making a note for now on implementation.
This is pretty close to what we want: all the initial project import is handled with chained async calls.
The only problem/issue that I'm experimenting now is that as
This message dissapears once the Celery task completes and I refresh the page.
I think this is because you updated the common submodule, you only need to rebase (the requirements were moved in other PR a long time ago).
Looks great! I raised question on the use of our notification backend, though I don't think it's a bad application -- just looking for some quick discussion there.
The rest of the PR makes sense though. I think we're in good shape as long as:
- When a webhook attachment fails, the requesting user (and only the requesting user) receives an on-site notification (no email) and the notification has a link to something actionable in the notification
- When a webhook attachment succeeds, the user gets a normal notification (non-sticky, doesn't need to be dismissed, no email)
3 notifications were shown, yes. We decided in the chat to remove the one from the template.
Doing QA, the only issue that I found is that importing the project, it failed to add the webhook, and you just delete the project... Since the notification is persistent you will end with an invalid notification that to be removed you have to click in the link from the notification which will lead you to a 404 page (project deleted) :/