Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bump sphinx default version to 1.7.4 #4035
I'm not sure how we handle this usually.
This is a big change that shouldn't produce builds without a pinned version to break but it could happen. I think it's good to have our main dependencies pinned to the latest versions, though.
Maybe, depending on how many projects break, we can tell the users to pin to their latest working sphinx version (1.6.5) or revert this PR.
The feature flag exists so we can monitor this at least a little bit. The first step is to see if projects with the feature flag (should already be using Sphinx 1.7 unless there is an override) are noticing higher than average build failures (compared to projects without the flag). This isn't perfect though. Next step would probably be verifying that projects with the feature flag build normally, are built with Sphinx 1.7, and are displayed correctly.
Perhaps some form of prod QA testing automation could help us here, like a QA test suite that hits the prod database to query for some of this in an automated way. Perhaps something we us to verify deploys? I'm just spitballing here though. We can test this manually for now.