Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add schema for configuration file with yamale #4084
referenced this pull request
May 11, 2018
This looks like a good approach. I like that it will do the validation for us, with us just maintaining the schema, instead of the entire validation code.
So I think there are two PRs happening here. The first is writing a schema file so we can verify our thoughts around our spec.
The second is moving to use yamale as an application level dependency and move our validation to use yamale internals. I don't think we've made this decision yet, and would probably duplicate a lot of existing code.
Let's discuss this change in another issue. Save some of this work for now, but this PR should be dialed back to just include a way to describe our spec via a schema file in our unit tests.
The schema looks great. All of the additions I can think of are not yet RTD features, so we can hold off on new additions for just right now.