Join GitHub today
Make the STABLE and LATEST constants overridable #4099
This looks useful. I definitely want to maintain backwards compat though. If the goal is to simply make it able to be changed with a setting, a much less invasive change would be to have the constants be able to read from a setting, instead of changing every instance of it.
I don't think we're ready to commit to this PR's approach in all our downstream dependencies, but I could perhaps be convinced if shown why the simpler settings-based approach can't work.
@ericholscher it will work on its own and we are currently using it. But i think that using plain settings for something that should be configurable would be cleaner. Anyway if you are fine with that approach I can update the PR. The smaller delta we have from upstream the better.