Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove Django deprecation warning #4112
The warning was
And we already have the debug option there
Also, there is a warning about Guardian
I think that setting is used in production, right?
Firstly, I'm happy you're taking care of this. It has been on my list for a while. This is safe to remove and the setting we have in the
TEMPLATES dict is sufficient. This PR is good to go!
I believe there is a small issue in our production settings, however. This change didn't introduce it. In our production settings that we have
TEMPLATE_DEBUG=False but the prod settings file doesn't change
settings.TEMPLATES['OPTIONS']['debug'] which I believe it should. I'll open a PR for that.