New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quiet mode to retrieve branches from mercurial #4114

Merged
merged 2 commits into from May 24, 2018

Conversation

Projects
None yet
5 participants
@cedk
Contributor

cedk commented May 19, 2018

Without the quiet mode, the current revision of the branch is also
displayed which breaks parse_branches.

Use quiet mode to retrieve branches from mercurial
Without the quiet mode, the current revision of the branch is also
displayed which breaks parse_branches.
@stsewd

This comment has been minimized.

Member

stsewd commented May 19, 2018

Thanks for this contribution, can you add a test for this? I'm not familiar with mercurial. So, can you paste the output of both commands?

@cedk

This comment has been minimized.

Contributor

cedk commented May 19, 2018

Here is an example of command outputs:

$ hg branches
default 6341:6836081bd4c4
4.8 6340:ee41804678df
4.0 6339:6d5b80d0ad01
4.2 6338:dca75e794c6e
4.4 6337:a68461f69157
4.6 6336:1a015ceaf9b8

$ hg branches --quiet
default
4.8
4.0
4.2
4.4
4.6

For the tests, it already test with the 'quiet' format. So I do not see what can I test more without installing mercurial.

@humitos

Thanks for this contribution.

It makes sense to me.

It would be good to add a comment in the parse_branches docstring with the output expected by the command (similar to the parse_tags).

@agjohnson

@cedk Thanks for the contribution! 🎉

I think the test failure is unrelated, but I'll trigger a retest. I think this change looks good for now otherwise

@agjohnson agjohnson added this to the 2.4 milestone May 22, 2018

@ericholscher ericholscher merged commit c3af2ec into rtfd:master May 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericholscher

This comment has been minimized.

Member

ericholscher commented May 24, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment